add -C target-cpu=mvp rust flag to build command#838
Merged
Conversation
agryaznov
requested review from
HCastano,
ascjones and
cmichi
as code owners
Contributor
Author
|
I think we should backport this to |
ascjones
approved these changes
Nov 22, 2022
Contributor
jup. I am curious if this actually resolves the bug. It is just a hunch of mine. |
athei
approved these changes
Nov 22, 2022
|
gm. when will there be v1 & v2 tags/releases with this inside? |
agryaznov
added a commit
that referenced
this pull request
Dec 9, 2022
Contributor
|
Should happen pretty soon. Probably today there should be a release. No promises, though. @agryaznov already started the branch. And I think we only backport this single chance for now. |
Contributor
Author
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightlyrust adds some new WASM features which are out of WASM MVP and hence not supported bypallet_contracts.This change should catch\avoid such cases on the
cargo contract buildstep.Fixes #832